Fix NoSuchMethodError when projects have OkHttp 3 dependency
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After updating to OkHttp v4, customers may experience
NoSuchMethodErrorwhen making requests with this library, if OkHttp v3 is taking precedence on the runtime classpath. Given that OkHttp v4 is binary compatible with OkHttp v3, this change reverts to using (now-deprecated) OkHttp methods that do not exist in v4.We cannot guarantee that we will never use any OkHttp v4 APIs, and the resolution to such issues may require managing the dependencies as discussed in #324. But for now, we can alleviate this issue for the majority of customers with this change.
References